Skip to content

[TVMC][microTVM] Fix TVMC AttributeError When USE_MICRO is OFF#9688

Merged
leandron merged 1 commit intoapache:mainfrom
mehrdadh:fix_tvmc_micro_import_error
Dec 9, 2021
Merged

[TVMC][microTVM] Fix TVMC AttributeError When USE_MICRO is OFF#9688
leandron merged 1 commit intoapache:mainfrom
mehrdadh:fix_tvmc_micro_import_error

Conversation

@mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Dec 9, 2021

This PR fixes issue #9679

cc @gromero @leandron

@mehrdadh mehrdadh changed the title [TVMC][microTVM] Fix TVMC Error When USE_MICRO is OFF [TVMC][microTVM] Fix TVMC AttributeError When USE_MICRO is OFF Dec 9, 2021
Copy link
Contributor

@gromero gromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehrdadh Thanks for fixing it. LGTM!

Out of curiosity, on which environment you were able to reproduce it? Was that on the RVM? I've tried on a few ones yesterday (like Ubuntu 20.04 + Python 3.9 5) but I was not able to reproduce it...

@gromero
Copy link
Contributor

gromero commented Dec 9, 2021

@mehrdadh btw, the PR title is cool, but the commit title is not as good as the PR title and when there is only one commit in the PR the title that will be used for the commit that gets merged is the one from the commit (if the PR has multiple commits the PR title is used instead). Hence it would be cool if next time (since we want to avoid a CI retrigger) we try to be consistent for the sake of merging better commit messages in general :)

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mehrdadh @gromero!

@leandron leandron merged commit f8f820e into apache:main Dec 9, 2021
@mehrdadh
Copy link
Member Author

mehrdadh commented Dec 9, 2021

@gromero this was on ubuntu 18.08 and I was using python3.6

No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.5 LTS
Release:        18.04
Codename:       bionic

Thanks for checking it. I think this clearly shows that we need nightly test of tlcpack on different OSs.

@mehrdadh mehrdadh deleted the fix_tvmc_micro_import_error branch December 9, 2021 15:33
mikepapadim pushed a commit to mikepapadim/tvm that referenced this pull request Dec 9, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 12, 2022
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
qsqqsqqsq-intellif pushed a commit to qsqqsqqsq-intellif/tvm that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants