[TVMC][microTVM] Fix TVMC AttributeError When USE_MICRO is OFF#9688
[TVMC][microTVM] Fix TVMC AttributeError When USE_MICRO is OFF#9688leandron merged 1 commit intoapache:mainfrom
Conversation
There was a problem hiding this comment.
@mehrdadh Thanks for fixing it. LGTM!
Out of curiosity, on which environment you were able to reproduce it? Was that on the RVM? I've tried on a few ones yesterday (like Ubuntu 20.04 + Python 3.9 5) but I was not able to reproduce it...
|
@mehrdadh btw, the PR title is cool, but the commit title is not as good as the PR title and when there is only one commit in the PR the title that will be used for the commit that gets merged is the one from the commit (if the PR has multiple commits the PR title is used instead). Hence it would be cool if next time (since we want to avoid a CI retrigger) we try to be consistent for the sake of merging better commit messages in general :) |
|
@gromero this was on ubuntu 18.08 and I was using python3.6 Thanks for checking it. I think this clearly shows that we need nightly test of tlcpack on different OSs. |
This PR fixes issue #9679
cc @gromero @leandron