Fix reduce NCHWc infer layout (do not keep reduced inner c when keepdims=false)#9821
Merged
comaniac merged 3 commits intoapache:mainfrom Jan 3, 2022
Merged
Fix reduce NCHWc infer layout (do not keep reduced inner c when keepdims=false)#9821comaniac merged 3 commits intoapache:mainfrom
comaniac merged 3 commits intoapache:mainfrom
Conversation
masahi
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Contributor
|
Thanks @masahi |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…ims=false) (apache#9821) * Fix reduce NCHWc infer layout (do not keep reduced inner c when keepdims=false) * black * lint
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…ims=false) (apache#9821) * Fix reduce NCHWc infer layout (do not keep reduced inner c when keepdims=false) * black * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9813
The error happened at
tvm/src/tir/ir/data_layout.cc
Lines 140 to 141 in 8131364
Cwhen it finds a "non-primal" axisc. In the test case in #9813, the reduction is over the channel dimension, so theCaxis would be gone unlesskeepdims = True. ButReduceInferCorrectLayouthad a bug where it always preserved the inner1cwhen the reduction is over the channel dimension. This resulted in an invalid layoutNHW1c.@ganler @comaniac