Skip to content

Conversation

@wForget
Copy link
Member

@wForget wForget commented Jan 13, 2026

What changes were proposed in this pull request?

  • Add cleaner ShuffleReadTimesSummary/ShuffleWriteTimesSummary entities
  • Make ShuffleType as an enumeration

Why are the changes needed?

for #2709

Fix serialization error when enabled spark.history.store.hybridStore.enabled

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Successfully tested in internal spark history server environment.

@wForget
Copy link
Member Author

wForget commented Jan 13, 2026

@zuston Could you please take a look?

@github-actions
Copy link

Test Results

 3 175 files  ±0   3 175 suites  ±0   6h 51m 54s ⏱️ +59s
 1 238 tests ±0   1 237 ✅ ±0   1 💤 ±0  0 ❌ ±0 
15 689 runs  ±0  15 674 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 483139c. ± Comparison against base commit 1365115.

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks for fixing this @wForget

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.59%. Comparing base (8ad0f8d) to head (52f2738).
⚠️ Report is 166 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2710      +/-   ##
============================================
+ Coverage     51.34%   51.59%   +0.24%     
+ Complexity     3615     3135     -480     
============================================
  Files           571      506      -65     
  Lines         32892    23998    -8894     
  Branches       2833     2183     -650     
============================================
- Hits          16890    12381    -4509     
+ Misses        14932    10840    -4092     
+ Partials       1070      777     -293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zuston zuston merged commit 2d5fc0a into apache:master Jan 13, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Some entities of spark uniffle ui cannot be deserialized in history server hybridStore

3 participants