Merged
Conversation
- Maven is now directly integrated with the docker-compose making it possible to start Unomi with `maven clean install` and `mvn docker:start`.
- Use project version for image tag - Increment Javascript timeout since Docker images execute seemingly slower on some installs (such as macOS) - Add a top-level profile to build Docker sub-project.
jbonofre
approved these changes
May 3, 2020
| </plugin> | ||
| <plugin> | ||
| <groupId>io.fabric8</groupId> | ||
| <artifactId>docker-maven-plugin</artifactId> |
Member
There was a problem hiding this comment.
FYI, in my branch, I replaced this with karaf-maven-plugin (as unomi is now a "real" karaf custom distribution).
Contributor
Author
There was a problem hiding this comment.
You replaced the docker-maven-plugin with the karaf-maven-plugin ? Or the dependency on the distribution?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a Maven - Docker integration which brings the following benefits:
mvn clean installand thenmvn docker:startin the Docker sub-projectmvn docker:push(it will use the project version as a tag, which should make it also easy to handle releases).