Unomi-336 fix past event count using custom timestamp#160
Merged
sergehuber merged 11 commits intoapache:masterfrom May 20, 2020
Merged
Conversation
Update fork from Original Unomi
Rebase fork master
…before increase the pastEvent counter by 1
sergehuber
reviewed
May 17, 2020
Contributor
sergehuber
left a comment
sergehuber
left a comment
There was a problem hiding this comment.
Thanks for the contribution. It would be great to have an integration test to make sure that both the regular and the case with an event with an older timestamp are processed
.../src/main/java/org/apache/unomi/plugins/baseplugin/actions/SetEventOccurenceCountAction.java
Outdated
Show resolved
Hide resolved
added 7 commits
May 18, 2020 09:14
…ation when adding events with custom timestamp
sergehuber
approved these changes
May 19, 2020
Contributor
sergehuber
left a comment
sergehuber
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks !
asfgit
pushed a commit
that referenced
this pull request
May 20, 2020
* fix(SetEventOccurenceCountAction.java) - check the event's timestamp before increase the pastEvent counter by 1 * fix(SetEventOccurenceCountAction.java) - change comment to Serge suggestion * rename(UpdateEventFromContextServletIT) - rename test class to "ContextServletIT" * improve(ContextServletIT) - refactor existing tests * improve(ContextServletIT) - delete indexes' CONTENT instead of deleting the indexes * feat(ContextServletIT) - remove sessions between tests * improve(TestUtils) - change "executeContextJSONRequest" function to static * feat(ContextServletIT) - add unit-tests for past-event-segment calculation when adding events with custom timestamp Co-authored-by: nlevitsky <Pitzek1305> (cherry picked from commit 5df3113)
nlevitsky
deleted the
UNOMI-336-fix_past_event_count_using_custom_timestamp
branch
shirbr
pushed a commit
to YotpoLtd/unomi-releases
that referenced
this pull request
Jul 21, 2020
* fix(SetEventOccurenceCountAction.java) - check the event's timestamp before increase the pastEvent counter by 1 * fix(SetEventOccurenceCountAction.java) - change comment to Serge suggestion * rename(UpdateEventFromContextServletIT) - rename test class to "ContextServletIT" * improve(ContextServletIT) - refactor existing tests * improve(ContextServletIT) - delete indexes' CONTENT instead of deleting the indexes * feat(ContextServletIT) - remove sessions between tests * improve(TestUtils) - change "executeContextJSONRequest" function to static * feat(ContextServletIT) - add unit-tests for past-event-segment calculation when adding events with custom timestamp Co-authored-by: nlevitsky <Pitzek1305>
shirbr
pushed a commit
to YotpoLtd/unomi-releases
that referenced
this pull request
Sep 16, 2020
* fix(SetEventOccurenceCountAction.java) - check the event's timestamp before increase the pastEvent counter by 1 * fix(SetEventOccurenceCountAction.java) - change comment to Serge suggestion * rename(UpdateEventFromContextServletIT) - rename test class to "ContextServletIT" * improve(ContextServletIT) - refactor existing tests * improve(ContextServletIT) - delete indexes' CONTENT instead of deleting the indexes * feat(ContextServletIT) - remove sessions between tests * improve(TestUtils) - change "executeContextJSONRequest" function to static * feat(ContextServletIT) - add unit-tests for past-event-segment calculation when adding events with custom timestamp Co-authored-by: nlevitsky <Pitzek1305>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA task -
https://issues.apache.org/jira/projects/UNOMI/issues/UNOMI-336
Check the event's timestamp before increasing the pastEvent counter by 1