Add profileId to the ContextRequest, and create profile with this id …#176
Merged
sergehuber merged 2 commits intoapache:masterfrom Jul 21, 2020
Merged
Conversation
Contributor
|
Hello Shir, Looks good to me. Could you provide an integration test to test this please ? Regards, |
sergehuber
requested changes
Jul 16, 2020
Contributor
sergehuber
left a comment
sergehuber
left a comment
There was a problem hiding this comment.
Could you please add integration tests to this PR ?
Thanks,
Regards,
Serge...
shirbr
force-pushed
the
context-servlet-create-profile
branch
from
994d0f4 to
f83a236
Compare
sergehuber
approved these changes
Jul 21, 2020
Contributor
sergehuber
left a comment
sergehuber
left a comment
There was a problem hiding this comment.
Thanks for adding the integration test, all looks good now I will merge it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…if provided