Conversation
sergehuber
reviewed
Aug 27, 2020
Jenkinsfile
Outdated
| // stage('Integration tests') { | ||
| // steps { | ||
| // echo 'Running integration tests' | ||
| // sh 'mvn test -Pci-build-itests' |
Contributor
There was a problem hiding this comment.
We can activate this if we change it to :
Suggested change
| // sh 'mvn test -Pci-build-itests' | |
| // sh 'mvn clean install -P integration-tests' |
Jenkinsfile-jdk11
Outdated
| // stage('Integration tests') { | ||
| // steps { | ||
| // echo 'Running integration tests' | ||
| // sh 'mvn test -Pci-build-itests' |
Contributor
There was a problem hiding this comment.
Same here:
Suggested change
| // sh 'mvn test -Pci-build-itests' | |
| // sh 'mvn clean install -P integration-tests' |
Contributor
There was a problem hiding this comment.
Thanks for the PR, looks good I just added some suggestions to be able to activate the integration tests which I think would be a good thing.
Member
Author
There was a problem hiding this comment.
@sergehuber I updated with this mvn -pl itests clean install -Pintegration-tests to not clean install all the project.
Taybou
approved these changes
Aug 27, 2020
sergehuber
approved these changes
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 2 Jenkins file for the new Apache CI:
A new job will be automatically created for every PR.
However, the PR has to rebase to have the Jenkin files to make it work.