Allow a single index for all events (remove monthly index)#199
Merged
sergehuber merged 1 commit intoapache:masterfrom Sep 22, 2020
Merged
Allow a single index for all events (remove monthly index)#199sergehuber merged 1 commit intoapache:masterfrom
sergehuber merged 1 commit intoapache:masterfrom
Conversation
#39) * feat(DATA_3381-merging-monthly-indices): remove itemsMonthlyIndexed from blueprint, put it in config instead * feat(DATA_3381-merging-monthly-indices): sending none if monthlyIndex should contain nothing
sergehuber
approved these changes
Sep 22, 2020
Contributor
sergehuber
left a comment
sergehuber
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks good to me !
amitco1
added a commit
to YotpoLtd/unomi-releases
that referenced
this pull request
Oct 21, 2020
#39) (apache#199) * feat(DATA_3381-merging-monthly-indices): remove itemsMonthlyIndexed from blueprint, put it in config instead * feat(DATA_3381-merging-monthly-indices): sending none if monthlyIndex should contain nothing Co-authored-by: amitco1 <amit@yotpo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow a single index for all events (remove monthly index)