Skip to content

WIP IT#276

Closed
Taybou wants to merge 1 commit intomasterfrom
IT-draft
Closed

WIP IT#276
Taybou wants to merge 1 commit intomasterfrom
IT-draft

Conversation

@Taybou
Copy link
Copy Markdown
Contributor

@Taybou Taybou commented Apr 1, 2021

PR Title format:

[UNOMI-XXX] Pull request title with JIRA reference

Please add a meaningful description for your change here


Please following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [UNOMI-XXX] - Title of the pull request
  • Provide integration tests for your changes, especially if you are changing the behavior of existing code or adding
    significant new parts of code.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    Copy the description to the related JIRA issue
  • Run mvn clean install -P integration-tests to make sure basic checks pass. A more thorough check will be
    performed on your pull request automatically.

Trivial changes like typos do not require a JIRA issue (javadoc, project build changes, small doc changes, comments...).

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Taybou
Copy link
Copy Markdown
Contributor Author

Taybou commented Apr 1, 2021

Handled by #277

@Taybou Taybou closed this Apr 1, 2021
@Taybou Taybou deleted the IT-draft branch April 1, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant