UNOMI-474 Add priorities to GraphQL field visibility providers#313
Merged
sergehuber merged 2 commits intomasterfrom Jun 25, 2021
Merged
UNOMI-474 Add priorities to GraphQL field visibility providers#313sergehuber merged 2 commits intomasterfrom
sergehuber merged 2 commits intomasterfrom
Conversation
Contributor
pmi
commented
Jun 23, 2021
pmi
commented
- Added priority field to graphql visibility provider interface
- Created composite graphql visibility provider to combine multiple visibility providers for graphql schema generation
- Added 2 visibility providers to graphql-providers-sample feature as example
sergehuber
requested changes
Jun 25, 2021
Contributor
sergehuber
left a comment
sergehuber
left a comment
There was a problem hiding this comment.
Hi @pmi thanks a lot for the PR. If you could just add a description to the sample provider that would be great! Otherwise it looks like it's ready to go.
...iders/src/main/java/org/apache/unomi/graphql/providers/sample/CDPVisibilityOnlyProvider.java
Show resolved
Hide resolved
- added javadoc - fixed a copy-paste typo in GraphQLSchemaUpdater.java
sergehuber
approved these changes
Jun 25, 2021
...iders/src/main/java/org/apache/unomi/graphql/providers/sample/CDPVisibilityOnlyProvider.java
Show resolved
Hide resolved
anatol-sialitski
pushed a commit
that referenced
this pull request
Sep 1, 2021
* UNOMI-474 Add priorities to GraphQL field visibility providers * UNOMI-474 Add priorities to GraphQL field visibility providers - added javadoc - fixed a copy-paste typo in GraphQLSchemaUpdater.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.