Skip to content

UNOMI-487 Add profile alias management to REST API and GraphQL API#403

Merged
sergehuber merged 3 commits intomasterfrom
Unomi-487-backup
Apr 14, 2022
Merged

UNOMI-487 Add profile alias management to REST API and GraphQL API#403
sergehuber merged 3 commits intomasterfrom
Unomi-487-backup

Conversation

@anatol-sialitski
Copy link
Contributor

@anatol-sialitski anatol-sialitski commented Apr 13, 2022

UNOMI-487 Add profile alias management to REST API and GraphQL API

In scope of this PR was implemented REST API and GraphQL API for profile aliases.

  1. Added new ES index profileAlias
  2. GraphQL API
  3. REST API
  4. Integration tests

Copy link
Contributor

@sergehuber sergehuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @anatol-sialitski. I just noticed some missing Javadoc comments on the ProfileService. Could you add them so I can accept this PR?
Thanks, regards,
Serge Huber.

Copy link
Contributor

@sergehuber sergehuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick changes. Looks good to me now, I will merge it.

@sergehuber sergehuber merged commit 9732487 into master Apr 14, 2022
@sergehuber sergehuber deleted the Unomi-487-backup branch April 14, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants