Skip to content

[UNOMI-564] - Misinformation in some descriptions in online site docs#409

Merged
sergehuber merged 3 commits intoapache:masterfrom
woonsan:bugfix/manual-trivial-fixes
May 25, 2022
Merged

[UNOMI-564] - Misinformation in some descriptions in online site docs#409
sergehuber merged 3 commits intoapache:masterfrom
woonsan:bugfix/manual-trivial-fixes

Conversation

@woonsan
Copy link
Copy Markdown
Contributor

@woonsan woonsan commented Apr 28, 2022

Some descriptions are not precise in online site docs. Should be self-explanatory in the changes.


  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [UNOMI-XXX] - Title of the pull request
  • [n/a] Provide integration tests for your changes, especially if you are changing the behavior of existing code or adding
    significant new parts of code.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    Copy the description to the related JIRA issue
  • Run mvn clean install -P integration-tests to make sure basic checks pass. A more thorough check will be
    performed on your pull request automatically.

Trivial changes like typos do not require a JIRA issue (javadoc, project build changes, small doc changes, comments...).
...oh well, already created one, sorry...

Copy link
Copy Markdown
Contributor

@sergehuber sergehuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Woosan,

Thanks a lot for the PR. It looks all good to me I'll merge them.

Regards,
Serge...

@sergehuber sergehuber merged commit f2972a1 into apache:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants