Skip to content

[UNOMI-592] - a tip for building on non-English Windows env#435

Merged
jkevan merged 2 commits intoapache:masterfrom
woonsan:feature/UNOMI-592
Jun 21, 2022
Merged

[UNOMI-592] - a tip for building on non-English Windows env#435
jkevan merged 2 commits intoapache:masterfrom
woonsan:feature/UNOMI-592

Conversation

@woonsan
Copy link
Copy Markdown
Contributor

@woonsan woonsan commented Jun 11, 2022

A tip in manual for non-English Windows users to avoid a build error due to the asciidoc-maven-plugin error.
Building on a non-English Windows machine, it is very likely to see a build error due to an encoding issue like the following example:

[ERROR] Failed to execute goal org.asciidoctor:asciidoctor-maven-plugin:1.6.0:process-asciidoc (output-html) on project unomi-manual: Execution output-html of goal org.asciidoctor:asciidoctor-maven-plugin:1.6.0:process-asciidoc failed: unknown encoding name - MS949 -> [Help 1]

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [UNOMI-XXX] - Title of the pull request
  • Provide integration tests for your changes, especially if you are changing the behavior of existing code or adding
    significant new parts of code.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    Copy the description to the related JIRA issue
  • Run mvn clean install -P integration-tests to make sure basic checks pass. A more thorough check will be
    performed on your pull request automatically.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@jkevan jkevan merged commit 41d5bf6 into apache:master Jun 21, 2022
@jkevan
Copy link
Copy Markdown
Contributor

jkevan commented Jun 21, 2022

Hello Woosan,

Thanks a lot for the PR.

Regards,
Kevan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants