[UNOMI-592] - a tip for building on non-English Windows env#435
Merged
jkevan merged 2 commits intoapache:masterfrom Jun 21, 2022
Merged
[UNOMI-592] - a tip for building on non-English Windows env#435jkevan merged 2 commits intoapache:masterfrom
jkevan merged 2 commits intoapache:masterfrom
Conversation
Fgerthoffert
approved these changes
Jun 21, 2022
Contributor
|
Hello Woosan, Thanks a lot for the PR. Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tip in manual for non-English Windows users to avoid a build error due to the asciidoc-maven-plugin error.
Building on a non-English Windows machine, it is very likely to see a build error due to an encoding issue like the following example:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[UNOMI-XXX] - Title of the pull requestsignificant new parts of code.
Copy the description to the related JIRA issue
mvn clean install -P integration-teststo make sure basic checks pass. A more thorough check will beperformed on your pull request automatically.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.