Merged
Conversation
Fgerthoffert
reviewed
Sep 6, 2022
|
|
||
| For example, the following event model in Apache Unomi 1.x: | ||
| The properties field in the events objects provided by unomi are now restricted by JSON schema. | ||
| It's not possible to add value in this property without adding the JSON schema which allows to add the properties. |
Contributor
There was a problem hiding this comment.
...now restricted by JSON schema. This means object properties must be declared in a JSON schema for an event to be accapted.
Instead of It's not possible[...]add the properties.
| The properties field in the events objects provided by unomi are now restricted by JSON schema. | ||
| It's not possible to add value in this property without adding the JSON schema which allows to add the properties. | ||
|
|
||
| If there is dynamic properties that you want to add to the event, you should use the new property of the event named flattenedProperties. |
Contributor
There was a problem hiding this comment.
You should rephrase a bit this paragraph to introduce flattenedProperties before instructing to use it.
A new property, flattenedProperties has been introduced to... this property is ...
Fgerthoffert
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/UNOMI-646