This repository was archived by the owner on May 12, 2021. It is now read-only.
Index functions#110
Closed
menakaj wants to merge 9 commits intoapache:masterfrom
menakaj:index_functions
Closed
Conversation
- extract common code in SequencePointable and ArrayPointable to AbstractSequencePointable - add code to extract sequences from arrays to ArrayPointable and use it in JnMembersScalarEvaluator and KeysOrMembersScalarEvaluator - reduce complexity of KeysOrMembersScalarEvaluator.evaluate by introducing a switch and pulling exception wrapping further out
|
|
||
| //Get the document node | ||
| IParser parser = new XMLParser(false, nodeIdProvider, nodeId); | ||
| XMLParser parser = new XMLParser(false, nodeIdProvider, nodeId); |
Contributor
There was a problem hiding this comment.
Why change from IParser?
Contributor
|
After these changes, every thing looks good from my perspective. Lets have Steven do the final review before the merge. |
Contributor
|
Just remembered. These changes to the return type should change the test results. |
Contributor
|
This seems fine to me. Please merge with master, squash into a single commit, and make a meaningful commit message. Don't forget to include the issue number in the first line and leave the second line blank |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.