This repository was archived by the owner on May 12, 2021. It is now read-only.
Closed
Conversation
|
|
||
| class WeatherConvertToJSON: | ||
|
|
||
| STATES = OrderedDict({ |
Contributor
There was a problem hiding this comment.
Can the STATES and MONTHS variables be shared between convertors?
Contributor
There was a problem hiding this comment.
It looks like many of the methods here can be shared with the WeatherConvertToXML. It would be nice to have "abstract" class that is shared for each convertor. (Not sure what its called in python.)
pavlopoul
force-pushed
the
christina/queries
branch
3 times, most recently
from
9b9e711 to
62ca88c
Compare
| @@ -0,0 +1,830 @@ | |||
| #!/usr/bin/env python | |||
Contributor
There was a problem hiding this comment.
Is this a new file or just being renamed?
Contributor
Author
There was a problem hiding this comment.
It is a new file that contains an abstract converter class. Then, according to which converter we need the methods are implemented in the corresponding converter. The two converters classes are, also contained in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.