Conversation
…rser to accept URI for hdfs
There was a problem hiding this comment.
This doesn't actually search subdirectories right?
There was a problem hiding this comment.
No it doesn't, do we want it to search subdirectories?
There was a problem hiding this comment.
Nope, but I think the description is misleading as it is.
There was a problem hiding this comment.
The collection function actually searching all sub directories and finds all the XML documents. Are you doing the same?
There was a problem hiding this comment.
Yes it does the same, I tested it with the ghcnd folder from the unit tests and works correctly.I will change the comment to be more clear.
|
A few comments from me |
pom.xml
Outdated
There was a problem hiding this comment.
Code style should match the document. 4 spaces for each indentation.
|
I added a few comments and will take a closer look once you have made the suggested changes. |
There was a problem hiding this comment.
Should we just create a separate constructor where the tag is added? Then tag can be final.
…m into one for both collection and collection-with-tag
…, moved logic for collection with tag function arguments to IntroduceCollectionRule class and removed CollectionWithTagRule
…7 to accept the multiexceptions, defined better the ip configuration in the documentation
|
|
||
|
|
||
| ---------------------------- | ||
| for $x in collectionwithtag("hdfs://user/hduser/store","book")/book |
There was a problem hiding this comment.
Update example - collection-with-tag.
|
The change has been merged under a different pull request. Nice to have this part of the code base! (Finally!) |
|
I am glad to hear and see this into the code! :D Thank you for the final steps! I am closing this pull |
3 participants
Contains the methods for reading collection of documents and single documents from HDFS, JUnit tests for reading collection of documents.
Retrieving of the hdfs configuration folder path is the old one yet, retrieving it by the system environments as well as the tests run on the user's hdfs setup and not a temp.These are to be changed in the next commit.