This repository was archived by the owner on May 12, 2021. It is now read-only.
Merged
Conversation
westmann
reviewed
Jun 5, 2017
Member
westmann
left a comment
westmann
left a comment
There was a problem hiding this comment.
Added a few comments.
On the "architecture diagram", I'd put "XQuery/JSONiq" on top of a single arrow for VXQuery (it's a single language - and it's a pretty useful feature to handle XML and JSON in the same query) while I'd put SQL++ and AQL on different arrows. Also I think that SQL++ should be to the left of AQL.
src/site/apt/index.apt
Outdated
| Apache VXQuery\x99 will be a standards compliant XML Query processor implemented in Java. | ||
| The focus is on the evaluation of queries on large amounts of XML data. | ||
| Specifically the goal is to evaluate queries on large collections of relatively small XML documents. | ||
| The XQuery processor supports JSONiq extension to XQuery. |
Member
There was a problem hiding this comment.
I'd call it "the JSONiq extension to XQuery" and I think that we should have a link to jsoniq.org somewhere (maybe here, but not necessarily).
|
|
||
| * Prepare your change for merge. | ||
|
|
||
| Squash your changes into a single commit with a nice commit message. |
Member
There was a problem hiding this comment.
It would be really nice if we had a consistent example with command lines to go along with this description - especially for the rebase/squash :)
| When merging the change, do not rebase. | ||
| When merging the change, do not ~rebase~. | ||
| Instead do a single merge commit into Apache VXQuery master. | ||
| Since the Pull Request now has a single commit, yan alternative would be to cherry pick that commit |
- Updating the index page to highlight JSONiq extension to XQuery. - Fixing issue with JavaDocs. - Adding contribution details with git commands.
prestoncarman
force-pushed
the
prestonc/release_prep
branch
from
4e5a05f to
37642be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started working on site updates based on recent work. This would be a great time to update the site and make a release of our query processor.