This repository was archived by the owner on May 12, 2021. It is now read-only.
Some changes to json-doc and implementation of jn:members#85
Closed
pavlopoul wants to merge 10 commits intoapache:masterfrom
Closed
Some changes to json-doc and implementation of jn:members#85pavlopoul wants to merge 10 commits intoapache:masterfrom
pavlopoul wants to merge 10 commits intoapache:masterfrom
Conversation
| <!-- jn:json-doc($uri as xs:string?) as document-node()? --> | ||
| <function name="jn:json-doc"> | ||
| <param name="uri" type="xs:string?"/> | ||
| <return type="item()"/> |
Contributor
There was a problem hiding this comment.
Should this be a json-item()?
| <!-- jn:json-doc($uri as xs:string?) as document-node()? --> | ||
| <function name="jn:json-doc"> | ||
| <param name="uri" type="xs:string?"/> | ||
| <return type="json-item()"/> |
Member
There was a problem hiding this comment.
I think that this should return a json-item()?.
|
|
||
| public static void readInDocFromPointable(UTF8StringPointable stringp, ByteBufferInputStream bbis, | ||
| DataInputStream di, ArrayBackedValueStorage abvs, XMLParser parser) throws HyracksDataException { | ||
| DataInputStream di, ArrayBackedValueStorage abvs, IParser parser) |
Contributor
There was a problem hiding this comment.
Only through HyracksDataException.
Contributor
|
Once you fix the exceptions, please squash the commit. |
Contributor
|
I believe this change has been merged under a different pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.