Retire Java8/Scala 2.11 support in restructure#389
Merged
Conversation
Contributor
|
I vote to also remove graphchi in this PR. |
zkaoudi
requested changes
Jan 12, 2024
Contributor
zkaoudi
left a comment
zkaoudi
left a comment
There was a problem hiding this comment.
There something wrong with the build and some pom file I guess. @juripetersen can you please check it out?
Contributor
Author
|
I am fixing the errors and will comment when this PRs actions can be run again @zkaoudi. |
Contributor
|
This PR closes #283 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is supposed to implement the restructure necessary to retire Scala 2.11/Java 8 as mentioned in #283.
As of now, the PR doesn't retire GraphChi, but after removing the support for Scala 2.11 and Java 8, it seems like this is the next step or should be included in this PR as well. If so, just let me know in a comment here.