Add LogisticRegressionOperator with API training support and integration test#570
Merged
zkaoudi merged 9 commits intoapache:mainfrom May 20, 2025
Merged
Add LogisticRegressionOperator with API training support and integration test#570zkaoudi merged 9 commits intoapache:mainfrom
zkaoudi merged 9 commits intoapache:mainfrom
Conversation
zkaoudi
requested changes
May 19, 2025
| val operator = new LogisticRegressionOperator(fitIntercept) | ||
| this.connectTo(operator, 0) | ||
| labels.connectTo(operator, 1) | ||
| new DataQuanta[LogisticRegressionModel](operator) |
Contributor
There was a problem hiding this comment.
Why create a new DataQuanta and not just output the operator as it's done for the other cases (see dlTrainingJava)?
zkaoudi
reviewed
May 20, 2025
zkaoudi
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for training logistic regression models in Apache Wayang via the public API.
Summary of changes:
Implemented
LogisticRegressionOperator(logical operator).Added
SparkLogisticRegressionOperatorfor Spark execution.Defined
LogisticRegressionModelinterface.Created
LogisticRegressionMappingto map the logical operator to Spark.Registered the mapping in Spark's ML plugin.
Extended the public API:
.trainLogisticRegression(...)toDataQuantaandDataQuantaBuilder.LogisticRegressionDataQuantaBuilderclass (consistent withdlTraining).Added an integration test:
testLogisticRegressionWithAPIinSparkIntegrationIT.javathat verifies:.loadCollection(...).trainLogisticRegression(...).predict(...).collect()Testing:
mvn clean install: all tests pass successfully.