A better solution to wicket-bundle? #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oops, should improve this somewhat |
asfgit
pushed a commit
that referenced
this pull request
Mar 14, 2014
…duration'
Remove detaching of the pages in RequestAdapter#commitRequest().
The page has been detached few calls ago:
In org.apache.wicket.request.cycle.RequestCycle#onDetach:
try
{
requestHandlerExecutor.detach(); // detaches pages #1
}
finally
{
listeners.onDetach(this); // detaches pages #2 (no more)
}
asfgit
pushed a commit
that referenced
this pull request
Jun 24, 2014
…duration'
Remove detaching of the pages in RequestAdapter#commitRequest().
The page has been detached few calls ago:
In org.apache.wicket.request.cycle.RequestCycle#onDetach:
try
{
requestHandlerExecutor.detach(); // detaches pages #1
}
finally
{
listeners.onDetach(this); // detaches pages #2 (no more)
}
(cherry picked from commit 48eaae6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was talked about on the dev list, but apparently I never generated a pull request? Oh well, here it is.