Changes to merge wicket-request and wicket-util into wicket-core #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Topping: can you please close this pull request because we don't have permissions. |
Member
Author
|
Haha, Martijn was right about "make work"... |
asfgit
pushed a commit
that referenced
this pull request
Mar 14, 2014
…duration'
Remove detaching of the pages in RequestAdapter#commitRequest().
The page has been detached few calls ago:
In org.apache.wicket.request.cycle.RequestCycle#onDetach:
try
{
requestHandlerExecutor.detach(); // detaches pages #1
}
finally
{
listeners.onDetach(this); // detaches pages #2 (no more)
}
asfgit
pushed a commit
that referenced
this pull request
Jun 24, 2014
…duration'
Remove detaching of the pages in RequestAdapter#commitRequest().
The page has been detached few calls ago:
In org.apache.wicket.request.cycle.RequestCycle#onDetach:
try
{
requestHandlerExecutor.detach(); // detaches pages #1
}
finally
{
listeners.onDetach(this); // detaches pages #2 (no more)
}
(cherry picked from commit 48eaae6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per conversation on wicket-dev [1]. These changes to POMs to merge wicket-request, wicket-util and wicket-core into an uber wicket-core that contains the contents of three modules. I've tested that the jars have exactly the same contents and the build executes perfectly.
[1] http://apache-wicket.1842946.n4.nabble.com/Restructure-Packaging-for-OSGi-tt3746217.html#a3748262