Cross-Site Websocket Hijacking Protection #112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 20, 2015 10:48
onAbort(). New broadcast message type: AbortedMessage introduced. New payload type: WebSocketAbortedPayload introduced. AbstractWebSocketProcessor closes connection when protection check fails.
Member
|
I'm afraid the PR cannot be used. |
Author
|
No problem! I will reapply them without formatting then! :) |
ghost
closed this
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to replace my previous attempt:
#110
Now I rebased my changes in my feature branch to master.
This pull request introduces a few new things in wicket-native-websocket-core. The basic idea is to prevent hijacking the websocket connections when the request arrives from an invalid origin. The valid origin domains can be configured by the new websocketsettings or can be completely turned off if protection is not necessary.
New classes:
New websocket settings:
And finally new methods on
WebSocketBehaviorandWebSocketResource:onAbort()The easiest way to understand what's going on is to run the test class:
WebSocketTesterProcessorTest