Skip to content

Conversation

@klopfdreh
Copy link
Member

Code review required - also if a back port is available. (to wicket-7.x)

https://issues.apache.org/jira/browse/WICKET-6051

@martin-g
Copy link
Member

The changes look good!
But isn't it better to use includes instead?
It is much easier to control what you want in then what you want out. For example when I add some third party library I'll have to investigate what CSS resources there are and exclude them.
It'd be much easier to list only the ones I'd like to process.

@klopfdreh
Copy link
Member Author

Okay - I will turn around that logic.

@klopfdreh
Copy link
Member Author

If I turn around that logic I will break the behavior, because you have to provide those settings and if users upgrading to the new wicket version and don't have set those css file names the functionality is broken.

@klopfdreh
Copy link
Member Author

The performance increased way better with the new regex. We should discuss changes in the jira ticket. I made a suggestion there.

@klopfdreh
Copy link
Member Author

Master: 274696a
Wicket-7.x: 9b8579f
Wicket-6.x: 9f6c69f

@klopfdreh klopfdreh closed this Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants