Skip to content

User guide - sample code fixes (misleading indentation, copy&pase errors...)#163

Closed
romanhuba wants to merge 9 commits into
apache:masterfrom
romanhuba:master
Closed

User guide - sample code fixes (misleading indentation, copy&pase errors...)#163
romanhuba wants to merge 9 commits into
apache:masterfrom
romanhuba:master

Conversation

@romanhuba
Copy link
Copy Markdown
Contributor

TextField's variable used for regexp pattern was named mail, renamed to regExpPatternTxt for consistency.

Edit: did some sample code formatting

amilor added 6 commits March 8, 2016 08:51
TextField for regexp pattern was named mail, renamed to regExpPatternTxt for consistency.
fixed formatting of sample java and html snippets, some of them were quiet cumbersome to read
@romanhuba
Copy link
Copy Markdown
Contributor Author

Just to clarify, I am not simply converting spaces to tabs or vice-versa to my liking. I fix indentation when a code in one scope has different levels of indentation (or different nested scopes and same indentation) which makes it hard to read.

@romanhuba romanhuba changed the title User guide - Wicket forms in detail - Input value conversion - sample code fix User guide - sample code fixes (misleading indentation, copy&pase errors...) Mar 8, 2016
@martin-g
Copy link
Copy Markdown
Member

martin-g commented Mar 8, 2016

Thanks!
I've merged the PR but I had to squash it to be able to merge it to 6.x/7.x and now GitHub doesn't detect it as merged.
Please close it because we don't have permissions!

@romanhuba
Copy link
Copy Markdown
Contributor Author

Changes have been merged, closing the PR as requested.

Thanks.

@romanhuba romanhuba closed this Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants