Merged
Conversation
This approach has two problems though: 1. For every call of getObject, setObject and detach the whole model chain will be evaluated again. 2. It's the same problem like with the implementation before. When the setObject is called and any value in the retrieval has been null, no object will be set, which is unlike the PropertyModel, which would initialize any values being null.
| T object = IModel.this.getObject(); | ||
| if (object != null) | ||
| { | ||
| IModel<R> model = mapper.apply(object); |
Member
There was a problem hiding this comment.
The result of mapper.apply() is used without checks in the other methods. I think they should have it too.
Member
|
Thanks for the PR, Matthias! Other Wicket devs seems to liked the idea of having those methods in IModel, so thanks for formatting the code too! :-) This |
Contributor
Author
|
Awesome! Should hopefully be fine now! Thanks again for being so open to the ideas! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the formatting and provided an idea for implementing flatMap in a lazy fashion.