Add more modal customizations#347
Merged
martin-g merged 1 commit intoapache:masterfrom Mar 5, 2019
andruhon:customise-modal
Merged
Add more modal customizations#347martin-g merged 1 commit intoapache:masterfrom andruhon:customise-modal
martin-g merged 1 commit intoapache:masterfrom
andruhon:customise-modal
Conversation
solomax
approved these changes
Jan 29, 2019
martin-g
approved these changes
Jan 29, 2019
Member
|
For completeness just to mention that these settings could be set by overriding |
Contributor
|
Hi! Is this change got stuck? Should I do anything to proceed? |
Member
|
I will create a ticket in JIRA for this PR and merge it. |
Member
martin-g
pushed a commit
that referenced
this pull request
Mar 5, 2019
WICKET-6640 Add settings for customizing the ModalWindow's spacing, header height and overflow (cherry picked from commit edf01e8)
Member
|
Thank you, @andruhon ! |
Contributor
|
Should I next time create a jira ticket for change like this? |
Contributor
|
@andreikondratev JIRA tickets helps to create release notes |
Member
|
Yes, most users don't read the git commit history to see what's new in a release. Wicket distributions (.tar.gz and .zip) contain RELEASE_NOTES file with the export from JIRA. GitHub releases (actually Git tags) are not official Apache releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More Modal settings as promised in discussion of #294 . Sorry it took longer than I expected, was buried in work.