WICKET-6660 do not trim PasswordTextField input#355
Closed
d3ns0n wants to merge 1 commit intoapache:masterfrom
d3ns0n:WICKET-6660
Closed
WICKET-6660 do not trim PasswordTextField input#355d3ns0n wants to merge 1 commit intoapache:masterfrom d3ns0n:WICKET-6660
d3ns0n wants to merge 1 commit intoapache:masterfrom
d3ns0n:WICKET-6660
Conversation
martin-g
approved these changes
Apr 30, 2019
Member
martin-g
left a comment
martin-g
left a comment
There was a problem hiding this comment.
I don't mind making this change in master branch, i.e. Wicket 9.x.
But it should not be backported to earlier versions because it is a behavioral change that may break existing applications.
Contributor
|
@d3ns0n please close this pull request if you're fine with Wicket continuing to trim passwords - IMHO it's a matter of taste so I'd prefer to keep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
override FormComponent.shouldTrimInput() in PasswordTextField to prevent passwords from being trimmed