This small change solve the issue WICKET-4517. #5
Closed
jordeu wants to merge 1 commit intoapache:masterfrom
Closed
This small change solve the issue WICKET-4517. #5jordeu wants to merge 1 commit intoapache:masterfrom
jordeu wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Hi, I just committed the change suggested by Andreas Pieber: * |
Author
|
Ok, perfect. Now I've been able to deploy wicket-extensions without any problem. |
klopfdreh
pushed a commit
to klopfdreh/wicket
that referenced
this pull request
Jul 19, 2020
martin-g
added a commit
that referenced
this pull request
Aug 27, 2020
…r Policy support (#442) * COOP and COEP Implementation (#5) * Initial coop implementation * Fixed typo +reformatting code * Update wicket-core/src/main/java/org/apache/wicket/coop/CoopConfiguration.java Co-authored-by: Sal <salchoman@gmail.com> * Update wicket-core/src/main/java/org/apache/wicket/coop/CoopConfiguration.java Co-authored-by: Sal <salchoman@gmail.com> * Updates based on comments on the PR * Initial COEP implementation that doesn't handle report-to and setting up a reporting endpoint * Added javadocs and reformatted code * Fixed typo in javadoc * Updated valid values for COOP, same-origin-allow-popups instead of same-site * Made builder methods public so they can be called from init() in a sample app, added default values for builder fields to avoid null pointer exceptions * making exempted paths a HashSet for faster lookup * Using Set instead of HashSet in the declaration of exemptedPaths + reformatting code * Reformatting code to match Wicket's style * Indentation fix for CoepMode enum * Added tests for each COOP value, inlined url argument for checkHeaders in tests, formatted log statement to include path variable for exempted paths Co-authored-by: Sal <salchoman@gmail.com> * Fixed typo in COEP debug statement * Refactoring configs into SecuritySettings for COOP and COEP * Renamed the request cycle listeners and tests with longer names of coop and coep, removed CoopConfiguration and CoepConfiguration files * Renamed securityInit() method to coopCoepInit() * Moved adding coop/coep listeners to validetInit in WebApplication * WICKET-6805 Formatting, cleanup and minor improvements Co-authored-by: Sal <salchoman@gmail.com> Co-authored-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the issue here:
https://issues.apache.org/jira/browse/WICKET-4517
Without this change it's impossible to deploy wicket-extensions in an OSGi container, because it depends on a package that it's not exported.