Cdi 1.1 0.3.snapshot #50
Conversation
Add unit test for non-void elements too
fix typo java 7 diamonds
…ge isn't visible on the page WICKET-5128 Allow for Testing Component relative Feedback-Messages in Wicket-Tester
We now correctly detect if the resource already ends with .min to avoid further unnecessary compression.
…to access private fields and methods
Package is split up into wicket-cdi-1.1-core and wicket-cdi-1.1-weld. Refactored some classes to use cdi injection instead of constructors. Worked with tomcat and glassfish in my limited testing.
CdiConfiguration is now built totally on @Inject dependencies.
Replaced with Producer method in cdiConfiguration.
Adds unique global setting for each app in a war file. Adds extension to WicketFilter to allow for cdi inject at App deployment. Added several tests.
|
@papegaaij Just merged CDI 1.1 support from Wicket 7 to Wicket 6. @ivaynberg ping. |
|
I've checked the code in Wicket 7, and did make some changes (see the git log on wicket-6.x). Most of it seems ok and with the small modifications, it works fine on our application. |
|
@papegaaij I see no commits in master from you today. All your commits are in wicket-6.x branch. |
|
I only backported wicket-cdi-1.1 from Wicket 7 to Wicket 6. Once I've got everything working, I'll forward port my changes to Wicket 7. I did not use this PR. It's impossible to verify the diffs in this PR: all kinds of things are mixed, it contains merges, formatting changes, etc. |
|
but wicket-cdi-1.1 in master was based on that PR... -igor On Fri, Nov 8, 2013 at 6:48 AM, Emond Papegaaij notifications@github.comwrote:
|
|
wicket-cdi-1.1 was introduced by earlier PRs (47 and 48, I think). |
|
Igor, John On Fri, Nov 8, 2013 at 4:22 PM, Igor Vaynberg notifications@github.comwrote:
|
|
my primary concern is the removal of features like auto conversations. i my second concern is that a lot of code has changed and no one went through my third concern is that the api has somewhat changed. i dont really see a ideally the pull requests wouldve gone like this (had they i mightve had
if they were separated like that we can easily follow and -igor On Fri, Nov 8, 2013 at 1:35 PM, John Sarman notifications@github.comwrote:
|
i write this code using ASL2 license, so i dont mind when other people take it, i give up my ownership at commit. its not about whose code it is or how much youve changed it, its a question of whether its changed for the better. at some point i will be using this code so i just want to make sure that i have a good experience using it. it may seem selfish, but its also why i contribute this code - so others can make it better. |
|
In the latest revision, the AutoConversation is supported. Just add On Fri, Nov 8, 2013 at 4:56 PM, Igor Vaynberg notifications@github.comwrote:
|
|
Please close this PR. |
8 participants
Major changes to internals. Now supports @Conversational(auto,propagation) annotation to allow pages to override global configuration. Added WicketCdiFilter to allow the Cdi functionality to be set before the apps are loaded. This allows for configuration of global settings in web.xml and for Injection at Application initialization. One can now put @Inject in the WebApplication class and use the variable in the init function or anywhere else. Added several tests for ConversationPropagation use cases. Reintroduced the original Configuration option as deprecated methods to allow easier transition from cdi 1.0 implementation. The Propagation and Auto can be programmatically changed at runtime if the calling code is in a non-transient conversation. Any changes to the global defaults are stored in a ConversationManager which is ConversationScoped. Adding the test helped to weed out many potential problems.