Skip to content

[WICKET-6972] Add Resource key to be logged on Warning in Localizer.java#508

Merged
martin-g merged 1 commit into
apache:masterfrom
renoth:master
Apr 15, 2022
Merged

[WICKET-6972] Add Resource key to be logged on Warning in Localizer.java#508
martin-g merged 1 commit into
apache:masterfrom
renoth:master

Conversation

@renoth
Copy link
Copy Markdown
Contributor

@renoth renoth commented Apr 5, 2022

Suggestion: It would be very helpful to log the Resource key as well to easier identify the problem.

Is this be security-sensitive? Can this be exploited somehow?

@martin-g
Copy link
Copy Markdown
Member

@renoth Thanks for the PR!
I think it is safe to log the key.

We also need a ticket in JIRA for the release changelog. Once you have a ticket id please update the PR title and the commit message with it. Thanks!

@renoth renoth changed the title Add Resource key to be logged on Warning in Localizer.java [WICKET-6972] Add Resource key to be logged on Warning in Localizer.java Apr 11, 2022
@martin-g martin-g merged commit b32846a into apache:master Apr 15, 2022
@martin-g
Copy link
Copy Markdown
Member

Thank you, @renoth !

martin-g pushed a commit that referenced this pull request Apr 15, 2022
@dashorst dashorst mentioned this pull request Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants