[WICKET-6972] Add Resource key to be logged on Warning in Localizer.java#508
Merged
Conversation
martin-g
approved these changes
Apr 11, 2022
Member
|
@renoth Thanks for the PR! We also need a ticket in JIRA for the release changelog. Once you have a ticket id please update the PR title and the commit message with it. Thanks! |
Member
|
Thank you, @renoth ! |
martin-g
pushed a commit
that referenced
this pull request
Apr 15, 2022
(cherry picked from commit b32846a)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion: It would be very helpful to log the Resource key as well to easier identify the problem.
Is this be security-sensitive? Can this be exploited somehow?