[WICKET-7035] fileCountMax is added

[solomax]

POC, please review :)

I'll add some tests a bit later

[martin-g]

I think it would be also fine to use long (primitive) as https://github.com/apache/commons-fileupload/blob/c4f32a13298f6b9561c136b61b23c9e2c6d82368/src/main/java/org/apache/commons/fileupload/FileUploadBase.java#L172
I doubt the default value of -1 will ever change.

[solomax]

@martin-g I would like to add setFileCountMax() to MultiFileUploadField (at line 225)
Shall I add logic for the case of multiple MultiFileUploadField in the form?

[solomax]

Other than that everything seems to work :)

[martin-g]

I would like to add setFileCountMax() to MultiFileUploadField (at line 225)

You mean to call form.setFileCountMax(this.max) ?
Why ? I think this is responsibility of the developer to set the max per Form. Wicket should not try to calculate it. Or should it ?!

[solomax]

You mean to call form.setFileCountMax(this.max) ?

yes

Why ? I think this is responsibility of the developer to set the max per Form. Wicket should not try to calculate it. Or should it ?!

in this particular case max is set for MultiFileUploadField but not for the form
so now developer should pass max for both form and field, which is Ok in case there are multiple file inputs, but seems to be sort-of-code-duplication in case there is only one MultiFileUploadField for the form

[martin-g]

In that case maybe it would be better to not do anything at line 225 but add logic to Form#onBeforeRender() (?!) that does something like:

 # pseudo code
if (maxFileCount == -1) {
  AtomicLong accumulator = new AtomicLong(0);
  visitAllMultipartFormComponents((mpfc) -> {accumulator.add(mpfc.getMax())});
  setMaxFileCount(accumulator.get());
}

[solomax]

@martin-g, @bitstorm I guess this one should be backported to 8.x as well?

[martin-g]

+1

…

On Fri, Mar 24, 2023, 07:27 Maxim Solodovnik ***@***.***> wrote: @martin-g <https://github.com/martin-g>, @bitstorm <https://github.com/bitstorm> I guess this one should be backported to 8.x as well? — Reply to this email directly, view it on GitHub <#561 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABYUQUUD2EI5CNUSNFPD3TW5UWFZANCNFSM6AAAAAAWA2AIVM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[solomax]

I'll merge this one into master after #565