Don't add xerces jars to ant's classpath

[elharo]

@SingingBush

[Copilot]

Pull Request Overview

This PR removes Xerces XML parser JARs (xml-apis.jar and xercesImpl.jar) from Ant's bootstrap classpath in the build scripts. Since Xerces-J is an XML parser project that builds these JARs as output, they should not be in Ant's classpath during the build initialization. The build.bat file explicitly states the classpath should be "minimum required to run ant" with "application dependent classpaths specified in build.xml."

• Removed xml-apis.jar from Ant's classpath in both build scripts
• Removed xercesImpl.jar from Ant's classpath in both build scripts

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
build.sh	Removed two lines that added xml-apis.jar and xercesImpl.jar to LOCALCLASSPATH for Ant bootstrap
build.bat	Removed two lines that added xml-apis.jar and xercesImpl.jar to LOCALCLASSPATH for Ant bootstrap

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[SingingBush]

interesting. Doesn't this mean that removing tools/xercesImpl.jar is fine though? I've been calling ant directly rather than using the build.sh script. This also indicates that perhaps xml-apis can be removed completely.

[elharo]

Probably, but it has to be done in the right order. Don't remove things while they're still referenced.

[elharo]

and there are other references to those files, so this alone is necessary but not sufficient to remove them

[SingingBush]

and there are other references to those files, so this alone is necessary but not sufficient to remove them

no, the build.xml does set a var that sets the xercesImpl.jar name but that is for the build output, not for using the old one that's in tools. However the entire content of the tools dir does get included in the zip and tar files that get created. However, that's probably not a good thing as it's essentially bundling an old release. If the zip and tar distributions need a xercesImpl.jar then it makes sense to use the one that's built from the sources rather than just having an old release in the git repo.