[XERCES-1781] Javadoc changes for AbstractSAXParser #74
Conversation
| * Send startPrefixMapping events | ||
| * Send startPrefixMapping events. | ||
| * | ||
| * @throws SAXException if an error occurs |
There was a problem hiding this comment.
is this thrown, ever? From the code it looks like it might not be.
There was a problem hiding this comment.
Not here but it's abstract class, so expect that other classes will override so want the docs to make sure they make sense when overridden
There was a problem hiding this comment.
abstract class but final method, so not overridden
There was a problem hiding this comment.
good point, I'll change it
There was a problem hiding this comment.
the underlying call to startPrefixMapping could throw depending on the handler implementation
| * Send startPrefixMapping events | ||
| * Send startPrefixMapping events. | ||
| * | ||
| * @throws SAXException if an error occurs |
There was a problem hiding this comment.
abstract class but final method, so not overridden
| * Send endPrefixMapping events | ||
| * Send endPrefixMapping events. | ||
| * | ||
| * @throws SAXException if an error occurs |
There was a problem hiding this comment.
I don't think this can be thrown either
There was a problem hiding this comment.
will fix shortly
There was a problem hiding this comment.
for this one the call to endPrefixMapping could throw depending on the handler implementation
|
I took another look at both of these. There are methods on the ContentHandler that are used within each which can throw (based on method signature of the ContentHandler interface. As implementations can be changed it's worth keeping these javadocs as-is. |
2 participants
No description provided.