Skip to content

Conversation

@aw-was-here
Copy link
Contributor

No description provided.

@aajisaka
Copy link
Member

Applied the patch locally and tested with https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh

$ python shelldocs/src/main/python/shelldocs.py --lint -i ~/git/github/hadoop/hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh -o out
ERROR:root:/Users/aajisaka/git/github/hadoop/hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh:2063: ERROR: function wait_process_to_die_or_timeout has no @replacerawtext

In the error message, @replacerawtext should be @replaceable.

@aw-was-here
Copy link
Contributor Author

Thanks!

I need to fix yetus' support too, since it won't know what to do about ERROR:root: as a prefix from logging. Although I should probably change the logging config really.

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the fix. Thank you!

$ python shelldocs/src/main/python/shelldocs.py --lint -i ~/git/github/hadoop/hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh -o out
/Users/aajisaka/git/github/hadoop/hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh:2046:ERROR: function wait_process_to_die_or_timeout has no @replaceable

@aw-was-here aw-was-here merged commit e341681 into apache:main Sep 28, 2021
@aw-was-here aw-was-here deleted the yetus1121 branch September 28, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants