YETUS-1150. handle verify_command failures better #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndimiduk
approved these changes
Apr 19, 2022
Member
ndimiduk
left a comment
ndimiduk
left a comment
There was a problem hiding this comment.
Skimmed over the change, looks reasonable to me.
| if ! verify_command "shellcheck" "${SHELLCHECK}"; then | ||
| add_vote_table_v2 0 shellcheck "" "Shellcheck was not available." | ||
| delete_test shellcheck | ||
| return 0 |
Member
There was a problem hiding this comment.
None of the other branches below need an explicit return value?
Contributor
Author
There was a problem hiding this comment.
Not really. I made this return explicit to match the other prechecks. Being explicit, it re-enforces that test-patch really shouldn't fail if a particular tool isn't around and we definitely don't want the rest of the code to continue since that has a few side-effects.
Contributor
Author
|
Thanks for the review @ndimiduk ! I'll go ahead and commit this one since we know why the action test is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.