YETUS-685. add junit xml as a reporting format by aw-was-here · Pull Request #48 · apache/yetus

aw-was-here · 2019-04-30T23:28:19Z

This is a very simple implementation that likely requires more work. But it does work for at least Circle CI and Gitlab to some degree.

apache-yetus · 2019-04-30T23:28:56Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/1/console in case of problems.

apache-yetus · 2019-04-30T23:53:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1411	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
0	mvndep	12	Maven dependency ordering for branch
		_ Patch Compile Tests _
0	mvndep	4	Maven dependency ordering for patch
+1	shellcheck	0	There were no new shellcheck issues.
+1	shelldocs	0	There were no new shelldocs issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	yamllint	2	There were no new yamllint issues.
		_ Other Tests _
+1	asflicense	15	The patch does not generate ASF License warnings.
		1467

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/1/artifact/out/Dockerfile
GITHUB PR	#48
Optional Tests	dupname asflicense yamllint shellcheck shelldocs
uname	Linux f85f8a126103 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	precommit/src/main/shell/personality/yetus.sh
git revision	master / `0255243`
Max. process+thread count	50 (vs. ulimit of 2000)
modules	C: . precommit U: .
Console output	https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/1/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.6.0 yamllint=1.12.1
Powered by	Apache Yetus 0.11.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.

apache-yetus · 2019-05-01T05:12:23Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/2/console in case of problems.

apache-yetus · 2019-05-01T05:36:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1401	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
0	mvndep	12	Maven dependency ordering for branch
		_ Patch Compile Tests _
0	mvndep	4	Maven dependency ordering for patch
+1	shellcheck	1	There were no new shellcheck issues.
+1	shelldocs	0	There were no new shelldocs issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	yamllint	0	There were no new yamllint issues.
		_ Other Tests _
+1	asflicense	16	The patch does not generate ASF License warnings.
		1458

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/2/artifact/out/Dockerfile
GITHUB PR	#48
Optional Tests	dupname asflicense yamllint shellcheck shelldocs
uname	Linux 5f4e945df985 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	precommit/src/main/shell/personality/yetus.sh
git revision	master / `0255243`
Max. process+thread count	51 (vs. ulimit of 2000)
modules	C: . precommit U: .
Console output	https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/2/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.6.0 yamllint=1.12.1
Powered by	Apache Yetus 0.11.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.

apache-yetus · 2019-05-01T05:57:44Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/3/console in case of problems.

apache-yetus · 2019-05-01T05:59:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	83	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
0	mvndep	11	Maven dependency ordering for branch
		_ Patch Compile Tests _
0	mvndep	4	Maven dependency ordering for patch
+1	shellcheck	0	There were no new shellcheck issues.
+1	shelldocs	0	There were no new shelldocs issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	yamllint	2	There were no new yamllint issues.
		_ Other Tests _
+1	asflicense	14	The patch does not generate ASF License warnings.
		136

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/3/artifact/out/Dockerfile
GITHUB PR	#48
Optional Tests	dupname asflicense yamllint shellcheck shelldocs
uname	Linux 1cdf6b833ac3 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	precommit/src/main/shell/personality/yetus.sh
git revision	master / `0255243`
Max. process+thread count	51 (vs. ulimit of 2000)
modules	C: . precommit U: .
Console output	https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/3/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.6.0 yamllint=1.12.1
Powered by	Apache Yetus 0.11.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.

apache-yetus · 2019-05-01T21:24:39Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/4/console in case of problems.

apache-yetus · 2019-05-01T21:29:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	192	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
0	mvndep	15	Maven dependency ordering for branch
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
-1	shellcheck	7	The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	shelldocs	2	There were no new shelldocs issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	yamllint	0	There were no new yamllint issues.
		_ Other Tests _
0	asflicense	35	ASF License check generated no output?
		319

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/4/artifact/out/Dockerfile
GITHUB PR	#48
Optional Tests	dupname asflicense yamllint shellcheck shelldocs
uname	Linux 4b4b264d5ccb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	precommit/src/main/shell/personality/yetus.sh
git revision	master / `0255243`
shellcheck	https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/4/artifact/out/diff-patch-shellcheck.txt
Max. process+thread count	47 (vs. ulimit of 2000)
modules	C: . precommit U: .
Console output	https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/4/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.6.0 yamllint=1.12.1
Powered by	Apache Yetus 0.11.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.

busbey · 2019-05-02T11:18:32Z

At first I was confused, then I got that this the report of all the yetus tests in the junit result format.

It feels weird for this to be in the junit plugin for some reason? I think because it shouldn't need someone to be relying on any junit testing of their actual source, right?

Also this addition makes it clearer to me that we shouldn't be conflating sources of changes to test with reporting mechanisms (not sure why the html report didn't).

Anywho. That's all stuff not really critical for this first pass.

Maybe too early to include docs? Should atleast make clearer in the cli help that if their project generates its own junit output this isn't going to aggregate it.

+1

aw-was-here · 2019-05-02T15:22:53Z

It feels weird for this to be in the junit plugin for some reason? I think because it shouldn't need someone to be relying on any junit testing of their actual source, right?

Correct. It was just more of "well, it's junit related so put in the junit.sh file so it is easy to find, I guess?" We should probably prioritize splitting test-patch.d up. Making robots.d separate has been very nice. haha.

too early

Yeah. This patch works on Circle CI and Gitlab CI but I cannot get Jenkins to take in the report. So I'm still trying to get that part working. I guess we could commit as is and then I could open up another to get Jenkins working with it, clean it up, etc. Thoughts?

busbey

yeah that all sounds fine for later.

aw-was-here · 2019-05-02T15:50:36Z

... and of course, I just had Jenkins work in my test bed. Let me clean up this patch and get it committed.

apache-yetus · 2019-05-02T15:55:11Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/5/console in case of problems.

apache-yetus · 2019-05-02T15:58:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	124	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
0	mvndep	11	Maven dependency ordering for branch
		_ Patch Compile Tests _
0	mvndep	4	Maven dependency ordering for patch
+1	shellcheck	0	There were no new shellcheck issues.
+1	shelldocs	0	There were no new shelldocs issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	yamllint	1	There were no new yamllint issues.
		_ Other Tests _
+1	asflicense	20	The patch does not generate ASF License warnings.
		189

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/5/artifact/out/Dockerfile
GITHUB PR	#48
Optional Tests	dupname asflicense yamllint shellcheck shelldocs
uname	Linux e74797c417af 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	precommit/src/main/shell/personality/yetus.sh
git revision	master / `0255243`
Max. process+thread count	50 (vs. ulimit of 2000)
modules	C: . precommit U: .
Console output	https://builds.apache.org/job/yetus-github-multibranch/job/PR-48/5/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.6.0 yamllint=1.12.1
Powered by	Apache Yetus 0.11.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.

aw-was-here · 2019-05-02T16:00:43Z

Jenkins test results

WOOT!

aw-was-here · 2019-05-02T16:03:38Z

Thanks for the review!

aw-was-here force-pushed the junit-out branch from f934a7a to f022ee4 Compare May 1, 2019 05:11

aw-was-here force-pushed the junit-out branch from f022ee4 to 189b52b Compare May 1, 2019 21:24

busbey approved these changes May 2, 2019

View reviewed changes

YETUS-685. add junit xml as a reporting format

4231368

aw-was-here force-pushed the junit-out branch from 189b52b to 4231368 Compare May 2, 2019 15:54

aw-was-here merged commit 1a55acd into apache:master May 2, 2019

aw-was-here deleted the junit-out branch May 2, 2019 18:06

Conversation

aw-was-here commented Apr 30, 2019

Uh oh!

apache-yetus commented Apr 30, 2019

Uh oh!

apache-yetus commented Apr 30, 2019

Uh oh!

apache-yetus commented May 1, 2019

Uh oh!

apache-yetus commented May 1, 2019

Uh oh!

apache-yetus commented May 1, 2019

Uh oh!

apache-yetus commented May 1, 2019

Uh oh!

apache-yetus commented May 1, 2019

Uh oh!

apache-yetus commented May 1, 2019

Uh oh!

busbey commented May 2, 2019

Uh oh!

aw-was-here commented May 2, 2019

Uh oh!

busbey left a comment

Choose a reason for hiding this comment

Uh oh!

aw-was-here commented May 2, 2019

Uh oh!

apache-yetus commented May 2, 2019

Uh oh!

apache-yetus commented May 2, 2019

Uh oh!

aw-was-here commented May 2, 2019

Uh oh!

aw-was-here commented May 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants