[YUNIKORN-869] Improve coverage of node_collection.go#405
Closed
0yukali0 wants to merge 18 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 69.08% 69.28% +0.19%
==========================================
Files 67 68 +1
Lines 9647 9803 +156
==========================================
+ Hits 6665 6792 +127
- Misses 2738 2769 +31
+ Partials 244 242 -2
Continue to review full report at Codecov.
|
wilfred-s
requested changes
Apr 14, 2022
Contributor
wilfred-s
left a comment
wilfred-s
left a comment
There was a problem hiding this comment.
Test are looking promising but they leave a number of checks out to make sure we correctly test things.
… same cases into GetNodeSortingPolicy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add some case to cover these functions
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-869
How should this be tested?
Use "make test" command in yonikorn repo and then use "go tool cover --func=coverage.txt" to check the result
Screenshots (if appropriate)
### Questions: * [ ] - The licenses files need update. * [ ] - There is breaking changes for older versions. * [ ] - It needs documentation.