[YUNIKORN-2797] Increase handlers.go test coverage#970
Closed
ryankert01 wants to merge 8 commits intoapache:masterfrom
Closed
[YUNIKORN-2797] Increase handlers.go test coverage#970ryankert01 wants to merge 8 commits intoapache:masterfrom
ryankert01 wants to merge 8 commits intoapache:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #970 +/- ##
==========================================
+ Coverage 80.95% 81.05% +0.10%
==========================================
Files 97 97
Lines 12525 12525
==========================================
+ Hits 10139 10152 +13
+ Misses 2116 2103 -13
Partials 270 270 ☔ View full report in Codecov by Sentry. |
manirajv06
requested changes
Sep 16, 2024
pbacsko
reviewed
Sep 17, 2024
manirajv06
approved these changes
Sep 18, 2024
Contributor
manirajv06
left a comment
manirajv06
left a comment
There was a problem hiding this comment.
looks good. Will merge after successful run.
Member
Author
|
I got it! We shouldn't assert statusOK in this function's test because the tested function will not set statusOK in the slope. |
Contributor
It should other way around, not equal to StatusInternalServerError. Anyways, not a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Increase test coverage and some refactor.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2797
How should this be tested?
Screenshots (if appropriate)
Questions: