[MINOR]Removed some codes using interpreterClassList#1085
Closed
jongyoul wants to merge 3 commits intoapache:masterfrom
Closed
[MINOR]Removed some codes using interpreterClassList#1085jongyoul wants to merge 3 commits intoapache:masterfrom
jongyoul wants to merge 3 commits intoapache:masterfrom
Conversation
Member
|
Iterating interpreterClassList is mainly for keeping order of interpreters defined in Therefore this PR will not only refactoring the code but also bring some user level behavior changes. |
Member
Author
|
@Leemoonsoo Could you please describe in details? Do you mean the order of interpreter tab? If it's what you said, That's sorted by group on front-side |
Member
Author
|
@Leemoonsoo I've figured out what you said. This PR changes the way to find a default interpreter, isn't it? |
Member
|
@jongyoul Yes, i thought so. |
Added sorting method for interpreter binding
Member
Author
|
@Leemoonsoo My last commit solves ordering interpreters. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Removing dependency from interpreterClassList because this prevent new interpreter without interpreterClassList from registering in Zeppelin.
What type of PR is it?
[Bug Fix | Refactoring]
Todos
What is the Jira issue?
N/A
How should this be tested?
It doesn't have any change on user level.
Screenshots (if appropriate)
Questions: