Cache zeppelin-web/node_modules on travis ci and see if it reduces CI failure on npm install #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I like it. |
1 task
Member
Author
|
@jongyoul Thanks for taking a look. I can see now travis caches zeppelin-web/node_modules directory in the last commit of this PR. |
Contributor
|
@Leemoonsoo What will happen when there is a new dependency? |
Member
Author
|
@corneadoug then new dependencies will be cached, too. |
Member
Author
|
I still see a lot of CI run fails on "npm install", so i'm merging this PR into master as a hotfix and see if it helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Recently CI build fails a lot on npm install on building zeppelin-web module with network issues.
This PR tries to cache zeppelin-web/node_modules on travis and see it it helps reducing network issues.
What type of PR is it?
Improvement
Todos