[ZEPPELIN-1691] Implement NotebookRepoSetting to ZeppelinHub notebookRepo#1681
Closed
anthonycorbacho wants to merge 2 commits intoapache:masterfrom
anthonycorbacho:ZEPPELIN-1691
Closed
[ZEPPELIN-1691] Implement NotebookRepoSetting to ZeppelinHub notebookRepo#1681anthonycorbacho wants to merge 2 commits intoapache:masterfrom anthonycorbacho:ZEPPELIN-1691
anthonycorbacho wants to merge 2 commits intoapache:masterfrom
anthonycorbacho:ZEPPELIN-1691
Conversation
…tory. This change will allow users to directly switch from instance without switching token in zeppelin-env.sh.
Contributor
Author
|
Please review otherwise i am merging it |
Member
|
@anthonycorbacho i'll look into this |
| try { | ||
| instances = getUserInstances(zeppelinHubUserSession); | ||
| } catch (IOException e) { | ||
| // user not logged |
Member
There was a problem hiding this comment.
why not logging some warning here?
Member
|
@anthonycorbacho tested and works as expected. may check comment for log, LGTM! |
Contributor
Author
|
@khalidhuseynov thanks for the review, i addressed it. Merging if no more discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Implement notebookRepo setting in ZeppelinHub notebook repo.
This change will allow users to directly switch from instance without switching token in
zeppelin-env.sh.What type of PR is it?
[Improvement]
What is the Jira issue?
How should this be tested?
You need to have a valid Zeppelinhub account.
You need to enable zeppelinhub notebook repo (only) in zeppelin-env.sh
Enable shiro and set it to use Zeppelinhub realm.
Start zeppelin, login, you will see your list of notebooks, if you want to switch instance, go to NotebookRepos, and edit.
Screenshots (if appropriate)
Questions: