Closed
Conversation
### What is this PR for? When you paste text on Windows, you may inadvertedly add some Carriage Return control characters along with it. When this happens in a Livy paragraph in Zeppelin 0.6.0, execution of that paragraph will fail with a "500 Internal Server Error" message. This is because `LivyHelper` does not properly sanitise its input when generating a JSON payload for the Livy server. This PR takes the subset for the resolution of [ZEPPELIN-1430](https://issues.apache.org/jira/browse/ZEPPELIN-1430/) that should resolve this issue. ### What type of PR is it? Bug Fix ### What is the Jira issue? <https://issues.apache.org/jira/browse/ZEPPELIN-1729/> ### How should this be tested? Paste the following code in a new paragraph, ensuring that lines are ended by CRLF rather than LF: %livy.pyspark import datetime import json This can be easily realised on Windows, by copy-pasting this code from Notepad. Then, try to execute the paragraph. Without the fix, a "500 Internal Server Error" message should appear. With the fix, the paragraph will successfully execute (and do nothing interesting). ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No.
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a CI test for #1705.