[ZEPPELIN-1789] Make exported data file name more explicit#1822
Closed
AhyoungRyu wants to merge 3 commits intoapache:masterfrom
Closed
[ZEPPELIN-1789] Make exported data file name more explicit#1822AhyoungRyu wants to merge 3 commits intoapache:masterfrom
AhyoungRyu wants to merge 3 commits intoapache:masterfrom
Conversation
Member
|
Thanks @AhyoungRyu for the improvement. How about use |
Contributor
Author
|
@Leemoonsoo Sounds good. Let me update then :) |
AhyoungRyu
force-pushed
the
ZEPPELIN-1789
branch
from
354e85f to
d7d0087
Compare
Contributor
Author
|
@Leemoonsoo Addressed your comment in d7d0087. Please check if you have time. |
Leemoonsoo
reviewed
Jan 3, 2017
| $scope.exportToDSV = function(delimiter) { | ||
| var dsv = ''; | ||
| var dateFinished = moment(paragraph.dateFinished).format('YYYY-MM-DD hh:mm:ss A'); | ||
| var exportedFileName = paragraph.title ? paragraph.title + '_' + dateFinished : 'Exported data_' + dateFinished; |
Member
There was a problem hiding this comment.
nit: shell we make file name starts with lower case?
data_ instead of Exported data_, what do you think?
Contributor
Author
|
@Leemoonsoo I've just updated as you said and the PR description as well. Please take a look :) |
Member
|
@AhyoungRyu Thanks~ LGTM! |
Contributor
Author
|
CI failure is not related this issue it's reported in ZEPPELIN-1857. Merge if there are no more comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Currently we can download table data set as
.csvor.tsvformat in Zeppelin note. But since the exported file name is always set asdata.csv, it will be difficult to distinguish the each file if user tries to export it several times. So I changed the naming rule like below.if the paragraph has title e.g.
this is title, then the exported csv file name will bethis is title_YYYY-MM-DD hh:mm:ss a.csv.if not, the file name will be
data_YYYY-MM-DD hh:mm:ss a.csv.Please see the short discussion in ZEPPELIN-1789 for the more details. I just made this PR by following one person's opinion who raised this issue (Ruslan Dautkhanov ). So if anyone has better idea, please feel free to share :)
What type of PR is it?
Improvement
What is the Jira issue?
ZEPPELIN-1789
How should this be tested?
zeppelin-webhttp://localhost:9000and go to Zeppelin-Spark tutorial noteIf the paragraph has title, then the exported file name will be
"paragraph_title_YYYY-MM-DD hh:mm:ss a".csv, if not, will be"data_YYYY-MM-DD hh:mm:ss a".csv.Screenshots (if appropriate)
Questions: