Skip to content

Conversation

@1ambda
Copy link
Member

@1ambda 1ambda commented Jan 6, 2017

What is this PR for?

Currently the tooltip for personalized mode is quite confusing. Since

  • tooltip text is {{Collaboration mode}}
  • and when i click the icon, dialog tell me {{Do you want to personalized your analysis?}}

Tooltips should tell us what we can do instead of just stating current state as other tooltips do

confusing-1

confusing-2

What type of PR is it?

[Improvement]

Todos

Nothing

What is the Jira issue?

ZEPPELIN-1912

How should this be tested?

  1. Enable shiro and login
  2. Check the tooltip text while switching modes

Screenshots (if appropriate)

After

switch-2

switch-1

Questions:

  • Does the licenses files need update? - NO
  • Is there breaking changes for older versions? - NO
  • Does this needs documentation? - NO

@felixcheung
Copy link
Member

LGTM

@cloverhearts
Copy link
Member

LGTM!

@khalidhuseynov
Copy link
Member

more intuitive this way, LGTM!

@prabhjyotsingh
Copy link
Contributor

LGTM!

@Leemoonsoo
Copy link
Member

LGTM and merge to master!

@asfgit asfgit closed this in 89eae21 Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants