ZEPPELIN-2241: JDBC interpreter throws npe on connecting to any db that has a schema with "null" name #2117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at has a schema with "null" name
Member
|
Hi @randerzander. Thanks for contribution.
|
Contributor
Author
|
Thanks for the link, @1ambda . Do I need to close and re-open the PR to get Travis to run the test now? |
Contributor
Author
Member
|
@randerzander Hi, it's flaky test. You can restart the failed job again using the
|
Member
|
I will test and give you feed back soon! |
1ambda
reviewed
Mar 13, 2017
| try { | ||
| while (schemas.next()) { | ||
| String schemaName = schemas.getString("TABLE_SCHEM"); | ||
| //Some databases will have schemas with no name |
Member
There was a problem hiding this comment.
MINOR: We can remove this comment, it's duplicated with the code line below.
Member
|
LGTM except one minor thing. |
felixcheung
approved these changes
Mar 14, 2017
Member
|
LGTM and merge to master and branch-0.7, if no further comments. |
asfgit
pushed a commit
that referenced
this pull request
Mar 15, 2017
…at has a schema with "null" name A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html Prevents JDBC interpreter from throwing a stacktrace when the database has a schema with no name (null). [Bug Fix] * [ ] - Task * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] https://issues.apache.org/jira/browse/ZEPPELIN-2241 Outline the steps to test the PR here. Use JDBC interpreter to connect to any database that has a schema without a name. Apache Phoenix in particular has such a schema by default. * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Randy Gelhausen <rgelhau@gmail.com> Closes #2117 from randerzander/master and squashes the following commits: 49d33f9 [Randy Gelhausen] Removing comment per feedback 79d8a23 [Randy Gelhausen] Added comment to the change 0101296 [Randy Gelhausen] ZEPPELIN-2241: JDBC interpreter throws npe on connecting to any db that has a schema with "null" name (cherry picked from commit 623b4ac) Signed-off-by: Lee moon soo <moon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
Prevents JDBC interpreter from throwing a stacktrace when the database has a schema with no name (null).
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2241
How should this be tested?
Outline the steps to test the PR here.
Use JDBC interpreter to connect to any database that has a schema without a name. Apache Phoenix in particular has such a schema by default.
Screenshots (if appropriate)
Questions:
No
No
No