ZEPPELIN-2261. Support to connect with livy through https#2139
Closed
zjffdu wants to merge 2 commits intoapache:masterfrom
Closed
ZEPPELIN-2261. Support to connect with livy through https#2139zjffdu wants to merge 2 commits intoapache:masterfrom
zjffdu wants to merge 2 commits intoapache:masterfrom
Conversation
zjffdu
force-pushed
the
ZEPPELIN-2261
branch
4 times, most recently
from
045261b to
fb92798
Compare
felixcheung
reviewed
Mar 16, 2017
| </tr> | ||
| <tr> | ||
| <td>zeppelin.livy.ssl.trustStore</td> | ||
| <td></td> |
Member
There was a problem hiding this comment.
could you add example of what they look like?
Contributor
Author
There was a problem hiding this comment.
It is just the path of truststore file, I explain it in Description column
| HttpClient httpClient = null; | ||
| if (livyURL.startsWith("https:")) { | ||
| String keystoreFile = property.getProperty("zeppelin.livy.ssl.trustStore"); | ||
| String password = property.getProperty("zeppelin.livy.ssl.trustStorePassword"); |
Member
There was a problem hiding this comment.
should check they are not emply/whitespace before proceeding?
Contributor
Author
There was a problem hiding this comment.
Fixed, and also make another improvement to create RestTemplate in constructor. Otherwise each livy rest api would construct a new RestTemplate.
zjffdu
force-pushed
the
ZEPPELIN-2261
branch
2 times, most recently
from
57ae807 to
efda062
Compare
zjffdu
force-pushed
the
ZEPPELIN-2261
branch
2 times, most recently
from
4a5cf72 to
d8b60a8
Compare
Member
|
is it possible to add tests for https? |
Contributor
Author
|
I am afraid not, ssh need keystore file which is host dependent. |
felixcheung
approved these changes
Mar 22, 2017
Member
|
merging if no more comment |
asfgit
pushed a commit
that referenced
this pull request
Apr 28, 2017
### What is this PR for? Livy server support https, but the currently livy interpreter doesn't support it. This PR is for for the supporting to connect with livy through https ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-2261 ### How should this be tested? Tested manually on livy server with ssl enabled. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #2139 from zjffdu/ZEPPELIN-2261 and squashes the following commits: 52fc204 [Jeff Zhang] address comment 53230c3 [Jeff Zhang] [ZEPPELIN-2261]. Support to connect with livy through https (cherry picked from commit 9d40013) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Livy server support https, but the currently livy interpreter doesn't support it. This PR is for for the supporting to connect with livy through https
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
How should this be tested?
Tested manually on livy server with ssl enabled.
Questions: