[ZEPPELIN-2315] (bug) new note.json is overwritten by old note.json (master, branch-0.7)#2256
Closed
1ambda wants to merge 1 commit into
Closed
Conversation
Member
Author
|
@jongyoul Please help review this. |
Member
Author
|
Do we need test for this? |
Member
|
How about to remove old result after merged to new one? |
Member
Author
|
Old version zeppelins will not render converted note.json. On the other hand, if we keep 'result', they can render last version of old format. Is it ok? |
Member
|
Ok make sense. LGTM |
asfgit
pushed a commit
that referenced
this pull request
Apr 18, 2017
…master, branch-0.7) ### What is this PR for? - `note.json` is converted every time - as a result, changes in `note.json` is overwritten by old `note.json` Occurs in **0.8.0-SNAPSHOT** and **branch-0.7** ### What type of PR is it? [Bug Fix] ### Todos NONE ### What is the Jira issue? [ZEPPELIN-2315](https://issues.apache.org/jira/browse/ZEPPELIN-2315) ### How should this be tested? 1. create a note in 0.6.0 which including graph 2. migrate it to 0.7.0+ (just copy dir) 3. open in Zeppelin 4. click other graph type rather than table (e.g `scatter chart`) 5. restart 7. should see the last change (graph) is persisted ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <1amb4a@gmail.com> Closes #2256 from 1ambda/ZEPPELIN-2315/should-convert-old-notebook-only-once and squashes the following commits: 4e77c0a [1ambda] fix: Convert old notebook format only once (cherry picked from commit 3366394) Signed-off-by: Jongyoul Lee <jongyoul@apache.org>
tinkoff-dwh
pushed a commit
to tinkoff-dwh/zeppelin
that referenced
this pull request
Apr 20, 2017
…master, branch-0.7) ### What is this PR for? - `note.json` is converted every time - as a result, changes in `note.json` is overwritten by old `note.json` Occurs in **0.8.0-SNAPSHOT** and **branch-0.7** ### What type of PR is it? [Bug Fix] ### Todos NONE ### What is the Jira issue? [ZEPPELIN-2315](https://issues.apache.org/jira/browse/ZEPPELIN-2315) ### How should this be tested? 1. create a note in 0.6.0 which including graph 2. migrate it to 0.7.0+ (just copy dir) 3. open in Zeppelin 4. click other graph type rather than table (e.g `scatter chart`) 5. restart 7. should see the last change (graph) is persisted ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <1amb4a@gmail.com> Closes apache#2256 from 1ambda/ZEPPELIN-2315/should-convert-old-notebook-only-once and squashes the following commits: 4e77c0a [1ambda] fix: Convert old notebook format only once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
note.jsonis converted every timenote.jsonis overwritten by oldnote.jsonOccurs in 0.8.0-SNAPSHOT and branch-0.7
What type of PR is it?
[Bug Fix]
Todos
NONE
What is the Jira issue?
ZEPPELIN-2315
How should this be tested?
scatter chart)Screenshots (if appropriate)
Questions: