[ZEPPELIN-2672] Fix interpreter repos url tooltip#2423
[ZEPPELIN-2672] Fix interpreter repos url tooltip#2423necosta wants to merge 4 commits intoapache:masterfrom
Conversation
| <ul class="noDot"> | ||
| <li class="liVertical" ng-repeat="repo in repositories"> | ||
| <a tabindex="0" class="btn btn-info" role="button" | ||
| popover-trigger="focus" |
There was a problem hiding this comment.
Can we replace all popover angualr directives?
There was a problem hiding this comment.
Yes. There was just one more. Fixed in latest commit.
There was a problem hiding this comment.
Then I think we can remove the popover directive related files as well.
There was a problem hiding this comment.
Checked tooltip now works well. +1
But the tooltip for the first repo button is trimmed. Can we set tooltip position for repo buttons?
| style="color: white;" | ||
| popover-trigger="focus" | ||
| popover-html-unsafe="{{prop.tooltip}}"></a> | ||
| uib-tooltip="{{prop.tooltip}}"></a> |
There was a problem hiding this comment.
|
Checked that works well. LGTM except for 2 comments i left. |
|
ping @necosta |
|
Yes, @1ambda , expect updates later today. Have a few challenges on the column selector script... |
|
@1ambda , ready for review. Thanks! |
| <li>Zeppelin consider values as discrete when the values contain string value | ||
| or the number of distinct values are bigger than 5% of total number of values.</li> | ||
| <li>Size field button turns to grey when the option you chose is not valid.</li>` | ||
| tooltip: `This option is only valid for numeric fields. |
There was a problem hiding this comment.
To me, it looked this message could be improved. Any suggestions, please let me know. I'm not sure my new sentence is clear as well :)
There was a problem hiding this comment.
Looks good to me. It's more concise.
| or the number of distinct values are bigger than 5% of total number of values.</li> | ||
| <li>Size field button turns to grey when the option you chose is not valid.</li>` | ||
| tooltip: `This option is only valid for numeric fields. | ||
| When data in each axis is discrete, |
1ambda
left a comment
1ambda
left a comment
There was a problem hiding this comment.
LGTM. merge if no more discussion
2 participants
What is this PR for?
Fixing regression on showing interpreter repos tooltip
What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?
Zeppelin > Interpreter > Repository > (Mouse over) central/local/other
Screenshots
After this fix:
Questions: